LILAC issueshttps://gitlab.bucknell.edu/lilac/LILAC/-/issues2019-07-26T11:54:48-04:00https://gitlab.bucknell.edu/lilac/LILAC/-/issues/59Clickable Kappa points on the Kappa Chart2019-07-26T11:54:48-04:00Lily RomanoClickable Kappa points on the Kappa ChartEnd of Summer '19Lily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/56Add validation on Scans Per Sample2019-07-18T17:48:13-04:00Lily RomanoAdd validation on Scans Per SampleEnsure there is a 1 in the first column of data. If any other value, provide feedback to the user that run is invalid.
- [ ] If there is a 1, do not continue to process the run and not display anything other than the error message.Ensure there is a 1 in the first column of data. If any other value, provide feedback to the user that run is invalid.
- [ ] If there is a 1, do not continue to process the run and not display anything other than the error message.End of Summer '19Lily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/55Consistent terminology2021-04-13T12:17:48-04:00Lily RomanoConsistent terminology- [ ] Run (instead of Experiment, Project)
- [ ] Scan (instead of Sample)
- [ ] Valid/Invalid (instead of Enable/Disable)
- [x] Superstaturation (instead of Super Saturation)
- [ ] Experiment Date => Run Start Date
- [ ] dN/dLogDp is con...- [ ] Run (instead of Experiment, Project)
- [ ] Scan (instead of Sample)
- [ ] Valid/Invalid (instead of Enable/Disable)
- [x] Superstaturation (instead of Super Saturation)
- [ ] Experiment Date => Run Start Date
- [ ] dN/dLogDp is concentrate - NOT *flow rate*Lily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/52Unit Tests2019-08-17T07:30:20-04:00Lily RomanoUnit Tests- [ ] Test [frozen app](https://docs.pytest.org/en/latest/example/simple.html#freezing-pytest) (Edit tests on main to verify log didn't exist first before the "create/delete" process)- [ ] Test [frozen app](https://docs.pytest.org/en/latest/example/simple.html#freezing-pytest) (Edit tests on main to verify log didn't exist first before the "create/delete" process)Lily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/51WET Code2019-07-09T20:59:41-04:00Lily RomanoWET Code- [ ] chemics.controller.Controller#align_smps_ccnc_data vs. chemics.controller.Controller#prepare_data_for_manual_inputs- [ ] chemics.controller.Controller#align_smps_ccnc_data vs. chemics.controller.Controller#prepare_data_for_manual_inputsLily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/50Rework wording on file prompts for user clarity2019-07-18T00:19:23-04:00Lily RomanoRework wording on file prompts for user clarity- [ ] Inform users on New Project that all files must be selected upfront. Otherwise, a new run must be started.- [ ] Inform users on New Project that all files must be selected upfront. Otherwise, a new run must be started.Lily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/49Resolve FutureWarning for scipy.signal.savgol_filter2019-06-20T16:19:37-04:00Lily RomanoResolve FutureWarning for scipy.signal.savgol_filterError Received:
> FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which w...Error Received:
> FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result. = a[a_slice]
* [ ] helper_functions.smooth
* [ ] helper_functions.heavy_smooth
* [ ] And as of 6/20 auto align algorithm that is not in live codeLily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/48If the smooth hf.method receives a list shorter than window size, it will error2019-06-21T10:31:13-04:00Lily RomanoIf the smooth hf.method receives a list shorter than window size, it will errorLily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/47Review program for Magic Numbers that should be constants2019-06-20T15:59:56-04:00Lily RomanoReview program for Magic Numbers that should be constantsLily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/46Add some type of settings persistance2019-07-09T20:59:32-04:00Lily RomanoAdd some type of settings persistanceAdd x axis of ratio graph maxAdd x axis of ratio graph maxLily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/45Reword the scan status section2021-04-13T12:17:37-04:00Lily RomanoReword the scan status section- [ ] Possible enums (check on pickling)
- [ ] Status persistence [Maybe a separate user enabled/disabled flag with message presentation]
- The code flagged the scan invalid for some reason
- The user marks the scan valid - The o...- [ ] Possible enums (check on pickling)
- [ ] Status persistence [Maybe a separate user enabled/disabled flag with message presentation]
- The code flagged the scan invalid for some reason
- The user marks the scan valid - The original codes are wiped out
- The user then marks the scan invalid again
- The original scan invalidity should be maintained somewhere. If the user marked it disabled again in the event of enabling it in error, they can no longer see the original statusEnd of Summer '19Lily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/43Progress Bar Code Issues2019-06-21T10:06:48-04:00Lily RomanoProgress Bar Code Issues- [ ] Add title to Progress Bar code that makes more sense - Currently, it's the method name and the user doesn't need to see that.
- [ ] controller.correct_charges does not have a message.- [ ] Add title to Progress Bar code that makes more sense - Currently, it's the method name and the user doesn't need to see that.
- [ ] controller.correct_charges does not have a message.Lily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/42Sigmoid model may be incorrect2019-07-23T15:15:32-04:00Lily RomanoSigmoid model may be incorrectNeed to determine how chemics is modeling sigmoid and verify it's processing it correctly.Need to determine how chemics is modeling sigmoid and verify it's processing it correctly.Penn StateLily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/40Need some type of error logging2021-04-13T12:16:56-04:00Lily RomanoNeed some type of error loggingLily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/39Documentation Website: Index links only work when on page in top level directory2019-07-09T20:59:19-04:00Lily RomanoDocumentation Website: Index links only work when on page in top level directoryLily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/38Calculation error of ave_smps_diameters2019-07-23T15:16:40-04:00Lily RomanoCalculation error of ave_smps_diametersCode found in controller.get_smps_counts
- [ ] Avg SMPS diameter should be the midpoint of time frame (10 readings per second). Keep in mind readings are in log and will need to be converted.Code found in controller.get_smps_counts
- [ ] Avg SMPS diameter should be the midpoint of time frame (10 readings per second). Keep in mind readings are in log and will need to be converted.Lily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/36More User Friendly way of switching between the Kappa Graph and the Alignment...2019-07-18T17:43:46-04:00Lily RomanoMore User Friendly way of switching between the Kappa Graph and the Alignment GraphEnd of Summer '19Lily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/35The Show Data button doesn't actually show data2019-07-18T17:43:46-04:00Lily RomanoThe Show Data button doesn't actually show dataWhat should it show?What should it show?End of Summer '19Lily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/34Add LICENSE file to repo2019-07-18T00:14:48-04:00Lily RomanoAdd LICENSE file to repo- [ ] Review packages for license requirements
- [ ] Create LICENSE.md- [ ] Review packages for license requirements
- [ ] Create LICENSE.mdLily RomanoLily Romanohttps://gitlab.bucknell.edu/lilac/LILAC/-/issues/33Update to QT52019-07-29T09:35:00-04:00Lily RomanoUpdate to QT5- [x] Upgrade out of python 2.7.16
- [x] Upgrade pyside to pyside2- [x] Upgrade out of python 2.7.16
- [x] Upgrade pyside to pyside2Lily RomanoLily Romano